StringUtils.abbreviate handles empty abbrevMarker #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringUtils.abbreviate would not abbreviate properly when an empty
String was passed to abbrevMarker or abbrevMarker is null
Expected behaviour:
abbreviate("much too long text", "", 13).equals("much too long")
Actual behaviour:
abbreviate("much too long text", "", 13).equals("much too long text")
Behaves the same when abbrevMarker is null.
Added if statements to handle empty and null abbrevMarker
Passed all tests
'origin/StringUtilsAbbreviateFixed'
Stzx
suggested changes
Nov 3, 2019
| return str; | ||
| } | ||
|
|
||
| if (abbrevMarker == null){ | ||
| return str.substring(0, maxWidth + 1); |
There was a problem hiding this comment.
StringUtils.abbreviate("a", null, 0, 10);May throw a StringIndexOutOfBoundsException.
| return str.substring(0, maxWidth + 1); | ||
| } | ||
| if (isEmpty(abbrevMarker)){ | ||
| return str.substring(0, maxWidth); |
There was a problem hiding this comment.
May throw a StringIndexOutOfBoundsException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringUtils.abbreviate would not abbreviate properly when an empty
String was passed to abbrevMarker or abbrevMarker is null
Expected behaviour:
abbreviate("much too long text", "", 13).equals("much too long")
Actual behaviour:
abbreviate("much too long text", "", 13).equals("much too long text")
Behaves the same when abbrevMarker is null.
Added if statements to handle empty and null abbrevMarker
Passed all tests