feat!: Bump min SDK to 24 #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nit: I think you meant "API 22 & API 23", and think it would be ideal if we could get this fixed in the commit message as well. |
Good catch. My morning coffee didn't kick in yet. |
Rationale: API 22 & API 23 both account for an insignificant part of the market share. While API 24 - API 26 has similar market share, we felt that bumping to API 26 from API 22 is too large of a jump. Legacy devices may be completely out of support by Google and may not be able to receive the latest webview version. As of writing, Chromium's latest tag shows they are using a Min SDK version of 24. (Ref: https://chromium.googlesource.com/chromium/src/+/refs/tags/113.0.5653.1/build/config/android/config.gni#46) Based on AOSP emulators, API 24 (Android 7.0) will ship with Chrome 52 webview, which has good support for ECMAscript 2015 (ES6) (Ref: https://caniuse.com/?search=es6) While in most cases, app users will likely have a modern webview vesion installed, this means you can be confident that the app user will have a chrome webview version with good ES6 support, even if they happen to be running on a factory versioned device. See the mailing thread for the full discussion: https://lists.apache.org/thread/zcgof080hdzzo2j96mjz0qpj0gotmn57
breautek
force-pushed
the
feat/bump-min-sdk-24
branch
from
8902835
to
6ad35a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 21 21
Lines 1751 1751
=======================================
Hits 1263 1263
Misses 488 488 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jcesarmobile
approved these changes
Mar 15, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
API 22 & API 23 both account for an insignificant part of the market share. While API 24 - API 26 has similar market share, we felt that bumping to API 26 from API 22 is too large of a jump.
Legacy devices may be completely out of support by Google and may not be able to receive the latest webview version. As of writing, Chromium's latest tag shows they are using a Min SDK version of 24. (Ref: https://chromium.googlesource.com/chromium/src/+/refs/tags/113.0.5653.1/build/config/android/config.gni#46)
Based on AOSP emulators, API 24 (Android 7.0) will ship with Chrome 52 webview, which has good support for ECMAscript 2015 (ES6) (Ref: https://caniuse.com/?search=es6)
While in most cases, app users will likely have a modern webview vesion installed, this means you can be confident that the app user will have a chrome webview version with good ES6 support, even if they happen to be running on a factory versioned device.
See the mailing thread for the full discussion:
https://lists.apache.org/thread/zcgof080hdzzo2j96mjz0qpj0gotmn57
Platforms affected
Motivation and Context
Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))