Fix for app restart when BT keyboard is connected in some devices #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avigation" as application is restarted when BT keyboard is connected in some devices In some devices (especially pixel) connecting with BT keyboard is resulting in application being restarted. The existing "keyboard" seems to be not sufficient as in this case it was triggering "navigation" change. https://stackoverflow.com/questions/25735227/bluetooth-keyboard-will-cause-activity-destroy-and-recreate/27238892#27238892
5r1m
changed the title
|
If there are no objections I'll merge sometime next week. Or earlier if I have other green votes. I do not believe this is a breaking change. https://developer.android.com/guide/topics/manifest/activity-element#config states:
For the "navigation". Cordova apps primarily operate in the webview, the webview should be able to handle input changes dynamically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
From API 13
Motivation and Context
To avoid app restart on connecting/disconnecting BT keyboard in some devices. Issue is faced by many and is also described here: https://stackoverflow.com/questions/25735227/bluetooth-keyboard-will-cause-activity-destroy-and-recreate/27238892#27238892
There is no easy way to extend this using config's.
Description
In some devices (especially pixel) connecting with BT keyboard is resulting in application being restarted. The existing "keyboard" seems to be not sufficient as in this case it was triggering "navigation" change.
Testing
Tested on problematic devices by connecting and disconnecting keyboards
Checklist
(platform)if this change only applies to one platform (e.g.(android))