Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress assets in /res (with tinypng.com) #672

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Conversation

janpio
Copy link
Member

@janpio janpio commented Feb 15, 2019

Motivation and Context

Projects include a lot of assets that are quite big. Can they be made smaller?

Description

Before: 1.61MB
After: 961kB

(used https://www.npmjs.com/package/tinypng-cli, tinypng -r -k ...)

Testing

none

We should make really sure the images aren't made worse.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • I've updated the documentation if necessary

@dpogue dpogue added this to the 8.0.1 milestone Mar 15, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@erisu erisu merged commit f2b84d8 into master Sep 7, 2019
@janpio janpio deleted the janpio-compress_res branch September 7, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants