Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ANDROID_HOME Test to Follow #656 Change #673

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 16, 2019

Platforms affected

none

Motivation and Context

There was a change in how the export var ANDROID_HOME is being set to follow Android documentation.

The existing tests which tested an alternative way of find ANDROID_HOME on top of what is in Android documentation were not updated.

The changes were valid and follows Android's documentation, therefore updating the tests were the appropriate solution.

Testing

  • Local Testing
  • CI Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Feb 16, 2019

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #673   +/-   ##
======================================
  Coverage    64.4%   64.4%           
======================================
  Files          18      18           
  Lines        1826    1826           
======================================
  Hits         1176    1176           
  Misses        650     650

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e390a...af99160. Read the comment docs.

@erisu erisu merged commit 576edb5 into apache:master Feb 18, 2019
@erisu erisu deleted the fix-unit-test branch April 4, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants