Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(travis): set dist: trusty in .travis.yml #777

Merged
merged 3 commits into from
Jul 14, 2019

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jul 14, 2019

to avoid errored Travis CI build on Node.js 12 (see WIP PR #770)

to avoid errored Travis CI build on Node.js 12
@brodycj brodycj requested a review from janpio July 14, 2019 17:24
@codecov-io
Copy link

codecov-io commented Jul 14, 2019

Codecov Report

Merging #777 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files          18       18           
  Lines        1818     1818           
=======================================
  Hits         1210     1210           
  Misses        608      608

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acad24d...1e5d971. Read the comment docs.

@janpio janpio changed the title ci(travis) set dist: trusty in .travis.yml ci(travis): set dist: trusty in .travis.yml Jul 14, 2019
@janpio
Copy link
Member

janpio commented Jul 14, 2019

Should we really merge this? In general this should work without these additions just out of the box :/

@brodycj
Copy link
Contributor Author

brodycj commented Jul 14, 2019

This would be needed if we want to test on Node.js 12, unless someone wants to do a bunch of extra investigation.

@janpio
Copy link
Member

janpio commented Jul 14, 2019

Maybe add a TODO that it should be removed asap?

@brodycj brodycj merged commit a5ad440 into apache:master Jul 14, 2019
@brodycj brodycj deleted the travis-ci-dist-trusty branch July 14, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants