Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept multiple mime types on file input #971

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Accept multiple mime types on file input #971

merged 1 commit into from
Jun 18, 2020

Conversation

jenthone
Copy link
Contributor

@jenthone jenthone commented May 6, 2020

Accept multiple mime types on file input

Platforms affected

Android

Motivation and Context

Accept multiple mime types when using file chooser

Description

Replace: #707
Fix: #695

Testing

Tested on Android devices.

Checklist

  • [ x] I've run the tests to see all new and existing tests pass
  • [ x] I added automated test coverage as appropriate for this change
  • [ x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [ x] I've updated the documentation if necessary

@brodycj

This comment has been minimized.

@brodycj
Copy link
Contributor

brodycj commented Jun 12, 2020

It looks like someone gave us a minimal reproduction in #695 (comment), needs our investigation.

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the original issue and confirmed that this PR resolves the issue: #695 (comment)

Confirmed that Intent.EXTRA_MIME_TYPES is usable by our min sdk.

lgtm 👍

Thank you for your contribution. I'd like to see a vote by at least one other PMC member before I merge.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Tested with various accept params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Intent type and category prevent file upload - [solution included]
4 participants