New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordova@8.1.0 does not work on Node.js 4 #339

Closed
brodybits opened this Issue Sep 27, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@brodybits
Contributor

brodybits commented Sep 27, 2018

C:\Users\brodybits
λ cordova --version
C:\Users\brodybits\AppData\Local\nvs\node\4.9.1\x64\node_modules\cordova\bin\cordova:24
const { events, CordovaError } = require('cordova-common');
      ^

SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:140:18)
    at node.js:1043:3

C:\Users\brodybits

While Node.js 4 support was dropped from Cordova 9, Node.js 4 should still be supported in patch and minor update of Cordova 8.

P.S. This issue was discovered while investigating issues reported in #337 and #338.

@brodybits brodybits added the bug label Sep 27, 2018

@brodybits brodybits self-assigned this Sep 27, 2018

@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Sep 27, 2018

@brodybits

This comment has been minimized.

Contributor

brodybits commented Sep 27, 2018

I think AppVeyor CI and Travis CI should have caught this one. This needs to be checked by AppVeyor CI and Travis CI in the future.

brodybits added a commit to brodybits/cordova-cli that referenced this issue Sep 27, 2018

Check that ./bin/cordova --version works on Travis
Ensure that bin script actually runs on current Node.js version
to detect and avoid bugs such as apache#339

raphinesse added a commit to raphinesse/cordova-cli that referenced this issue Sep 27, 2018

@janpio

This comment was marked as outdated.

Contributor

janpio commented Sep 27, 2018

Should the title of this issue start with cordova@8.1.0 ... instead of npm@8.1.0 ...?

@raphinesse raphinesse changed the title from npm@8.1.0 does not work on Node.js 4 to cordova@8.1.0 does not work on Node.js 4 Sep 27, 2018

@janpio

This comment has been minimized.

Contributor

janpio commented Sep 27, 2018

FYI: This is causing plugin CI tests to fail. Example: #339

brodybits added a commit that referenced this issue Sep 27, 2018

Check that bin/cordova works on Travis CI (#343)
Ensure that bin script actually runs on current Node.js version
to detect and avoid bugs such as #339

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

brodybits added a commit to brodybits/cordova-cli that referenced this issue Sep 27, 2018

Check that bin/cordova works on Travis CI (apache#343)
Ensure that bin script actually runs on current Node.js version
to detect and avoid bugs such as apache#339

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

brodybits added a commit that referenced this issue Sep 27, 2018

Check that bin/cordova works on Travis CI (#343) (#344)
Ensure that bin script actually runs on current Node.js version
to detect and avoid bugs such as #339

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

@janpio janpio removed this from 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Sep 27, 2018

@brodybits

This comment has been minimized.

Contributor

brodybits commented Sep 27, 2018

This issue should be resolved in version 8.1.1, closing.

@brodybits brodybits closed this Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment