Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(android) Replace deprecated android command with avdmanager #533

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

artlogic
Copy link
Contributor

@artlogic artlogic commented Sep 20, 2020

Platforms affected

Android

Motivation and Context

The android command is deprecated. When you run the command, it displays the following:

*************************************************************************
The "android" command is deprecated.
For manual SDK, AVD, and project management, please use Android Studio.
For command-line tools, use tools/bin/sdkmanager and tools/bin/avdmanager
*************************************************************************
Running /path/to/android-sdk/tools/bin/avdmanager list target

On many systems the android command isn't even in the PATH and so attempting to run the original command fails.

Description

Replaced the android command with avdmanager as suggested by the displayed warning.

Testing

I made the change locally and tested by running cordova info.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

(this issue was found by the team working on https://volt.build/)

The `android` command is deprecated. When you run the command, it displays the following:

```
*************************************************************************
The "android" command is deprecated.
For manual SDK, AVD, and project management, please use Android Studio.
For command-line tools, use tools/bin/sdkmanager and tools/bin/avdmanager
*************************************************************************
Running /path/to/android-sdk/tools/bin/avdmanager list target
```

On many systems the `android` command isn't even in the PATH and so attempting to run the original command fails.
@timbru31 timbru31 merged commit 7f89fce into apache:master Sep 24, 2020
@timbru31
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants