fix(ConfigParser): ImageResources constructor #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous ImageResources constructor did not cover the case where a single integer argument is given to construct an empty array of the given length. This broke the `map` method since it uses that constructor variant. This commit fixes that situation by using a static factory method instead of overriding the native Array constructor.
erisu
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The previous
ImageResourcesconstructor did not cover the case where a single integer argument is given to construct an empty array of the given length. This broke themapmethod since it uses that constructor variant.Description
This PR fixes that situation by using a static factory method instead of overriding the native Array constructor.
Testing
New regression test passes