Skip to content

Conversation

@brody4hire
Copy link

Using a real singleton object means that we would no longer have to follow the cordova-common singleton rule when publishing tools releases.

We may need to increase the minor version number if this change is included in cordova-common@3.

I would love to get this into the Cordova 9 release as discussed in apache/cordova#10, if possible.

Christopher J. Brody and others added 2 commits December 18, 2018 22:17
and replace var with const & let

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Darryl Pogue <darryl@dpogue.ca>
Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Darryl Pogue <darryl@dpogue.ca>
@brody4hire brody4hire requested review from dpogue and erisu December 19, 2018 03:35
@dpogue
Copy link
Member

dpogue commented Dec 19, 2018

Does EVENTS_RECEIVER also need to make sure there is only ever one instance?

@brody4hire
Copy link
Author

Whichever CordovaEventEmitter instance is used should always use the same EVENTS_RECEIVER variable, from the same events.js module.

@brody4hire brody4hire merged commit 1bbc93d into apache:master Dec 20, 2018
@brody4hire brody4hire deleted the events-singleton branch December 20, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants