Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cordova-windows] dealing with template/Properties/Default.rd.xml #106

Closed
brodycj opened this issue Jul 27, 2018 · 2 comments
Closed

[cordova-windows] dealing with template/Properties/Default.rd.xml #106

brodycj opened this issue Jul 27, 2018 · 2 comments

Comments

@brodycj
Copy link

brodycj commented Jul 27, 2018

I have uncovered a couple issues with template/Properties/Default.rd.xml:

  • CB-14224 - running coho audit-license-headers -r windows gives a message that template/Properties/Default.rd.xml is missing the license header
  • CB-14225 - misspelling in sample Namespace serialize attribute name

along with an additional issue that seems to be unsolved:

  • CB-13834 - problem building with build with params --release --bundle --archs="x64 x86 arm" on AppVeyor CI

I start to wonder if we should even keep template/Properties/Default.rd.xml in future releases. The following observations indicate to me that xxxx is only needed for projects using C# plugins:

I can think of the following possible alternatives:

@janpio
Copy link
Member

janpio commented Jul 27, 2018

I ignored this problem and file with the last release because it was not that easy to find out more about it.

But the PR that added this file indicates it is there for a reason:

CB-12499 UWP: Dependent external libraries specified as resource-file not being referenced in Release mode

Adds Default.rd.xml to Windows 10 project template making an app metadata to be available for reflection at runtime

apache/cordova-windows@d5ddcb4#diff-c54bf1c523e7312aae8e89dc03ae16dd

Original JIRA issue with more context:
https://issues.apache.org/jira/browse/CB-12499

(As cordova-windows has issues, this issue here could very well be placed over there instead of in this unconnected repo)

@brodycj
Copy link
Author

brodycj commented Aug 1, 2018

Continued in apache/cordova-windows#228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants