Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Splash Screen handling #48

Merged
merged 3 commits into from
May 27, 2019
Merged

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented Apr 18, 2019

Platforms affected

electron

Motivation and Context

Fixes #47

Description

Allow users to place the splash screen image inside any folder. If the user defines the correct location in the config.xml, we take that image and place in the appropriate folder in the {project_root}/platfroms/electron/. As well, set the correct source in the {project_root}/platfroms/electron/config.xml file.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         569    600   +31     
=====================================
+ Hits          569    600   +31
Impacted Files Coverage Δ
bin/templates/cordova/lib/prepare.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b9f8d...fa3974f. Read the comment docs.

Co-Authored-By: エリス <erisu@users.noreply.github.com>
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored-By: エリス <erisu@users.noreply.github.com>
@erisu erisu merged commit 454656b into apache:master May 27, 2019
@GedasGa GedasGa deleted the fix-splash-screen branch June 17, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use splash screen, if stored outside the www folder
3 participants