Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maintainer option from the Linux build json file #57

Merged
merged 1 commit into from
May 27, 2019

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented May 20, 2019

Platforms affected

electron

Motivation and Context

Remove the maintainer option build/linux.json, as maintainer and vendor defaults to the author value set in the {project_root}/platforms/electron/www/package.json. I believe it's unnecessary to get the option from the package.json file and then manually append it to the build/linux.json file.

Testing

Built all available packages for Linux. As well, ran npm t.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #57   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         569    569           
=====================================
  Hits          569    569
Impacted Files Coverage Δ
bin/templates/cordova/lib/build.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf4945...bf3a30f. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #57   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         569    569           
=====================================
  Hits          569    569
Impacted Files Coverage Δ
bin/templates/cordova/lib/build.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf4945...bf3a30f. Read the comment docs.

@erisu erisu added this to the 1.1.0 milestone May 27, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
This is safe for minor release. It does not break an existing project with past releases. It prepares for fixing a known issue.

@erisu erisu merged commit 639b0c7 into apache:master May 27, 2019
@GedasGa GedasGa deleted the remove-maintainer-linux branch June 17, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants