Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDVWebViewEngineConfigurationDelegate to expose the WKWebViewConfiguration #1157

Closed

Conversation

msmtamburro
Copy link
Contributor

@msmtamburro msmtamburro commented Oct 2, 2021

Platforms affected

iOS

This can be merged after #1272

Motivation and Context

CDVWebViewEngine needs a way to set the websiteDataStore of its configuration.

Fixes:
#900

Description

Adds and exposes a protocol, CDVWebViewEngineConfigurationDelegate, which allows access to the configuration.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #1157 (fb215c8) into master (f804a42) will increase coverage by 78.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1157       +/-   ##
===========================================
+ Coverage        0   78.26%   +78.26%     
===========================================
  Files           0       15       +15     
  Lines           0     1767     +1767     
===========================================
+ Hits            0     1383     +1383     
- Misses          0      384      +384     
Impacted Files Coverage Δ
lib/versions.js 89.36% <0.00%> (ø)
lib/run.js 21.97% <0.00%> (ø)
lib/create.js 95.83% <0.00%> (ø)
lib/build.js 63.69% <0.00%> (ø)
lib/listEmulatorImages.js 100.00% <0.00%> (ø)
lib/BridgingHeader.js 95.45% <0.00%> (ø)
lib/listEmulatorBuildTargets.js 96.77% <0.00%> (ø)
lib/plugman/pluginHandlers.js 90.05% <0.00%> (ø)
lib/listDevices.js 100.00% <0.00%> (ø)
lib/Api.js 71.76% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpogue
Copy link
Member

dpogue commented Oct 2, 2021

The CDVWebViewEngineConfigurationDelegate work has already been merged to master, and the extra commits make it quite hard to see what the actual change is here.

Can you rebase so that this includes only the commit related to data storage?

@msmtamburro msmtamburro changed the title Issue 900 website data store Add CDVWebViewEngineConfigurationDelegate to expose the WKWebViewConfiguration Oct 2, 2021
@msmtamburro
Copy link
Contributor Author

msmtamburro commented Oct 2, 2021 via email

@globules-io
Copy link

@msmtamburro was this pull request final? Still marked as Draft? Is this pull request fully working ?

@msmtamburro msmtamburro marked this pull request as ready for review October 19, 2022 15:51
@msmtamburro msmtamburro marked this pull request as draft November 22, 2022 19:00
@msmtamburro
Copy link
Contributor Author

Sorry it took so long to get back to you on this, but good news: nothing to do here. The commits in this PR safely made it to master in an earlier PR. I'll close this, and the associated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants