-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDVWebViewEngineConfigurationDelegate to expose the WKWebViewConfiguration #1157
Add CDVWebViewEngineConfigurationDelegate to expose the WKWebViewConfiguration #1157
Conversation
…View configuration (apache#900)
… conforming plugins use it
…ation with configuration
…iewWithFrame chore: clean up newCordovaViewWithFrame in order to extract initializ…
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
===========================================
+ Coverage 0 78.26% +78.26%
===========================================
Files 0 15 +15
Lines 0 1767 +1767
===========================================
+ Hits 0 1383 +1383
- Misses 0 384 +384
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The Can you rebase so that this includes only the commit related to data storage? |
Yes! Just lost my access to push changes from work, so it may be a while.
|
@msmtamburro was this pull request final? Still marked as Draft? Is this pull request fully working ? |
…nto issue_900_websiteDataStore
Sorry it took so long to get back to you on this, but good news: nothing to do here. The commits in this PR safely made it to master in an earlier PR. I'll close this, and the associated issue. |
Platforms affected
iOS
This can be merged after #1272
Motivation and Context
CDVWebViewEngine needs a way to set the websiteDataStore of its configuration.
Fixes:
#900
Description
Adds and exposes a protocol, CDVWebViewEngineConfigurationDelegate, which allows access to the configuration.
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)