Don't write spec to podfile when it's an empty string #577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
When plugin framework tag contains an empty spec value (
spec=""
), Podfile becomes malformed andpod install
command fails withExample:
Creates
Proposed change checks for an empty spec value and doesn't write version number:
Description
I'm not sure if it's a bug in cordova-ios or specific plugin (cordova-plugin-firebase-crashlytics).
However cordova documentation for the framework tag doesn't specify if the spec attribute can be omitted so it seems valid to me to use empty value.
Testing
cordova plugin add cordova-plugin-firebase-crashlytics --verbose
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)