GH-540: Fix copy-www-build-step without shelljs #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There didn't seem to be a compelling reason to keep this as JavaScript since it was primarily just shelling out to run various commands. By keeping it in bash, we can significantly simplify the invocation in the xcodeproj file and we can run it without a dependency on shelljs. I also moved it into a Scripts folder inside the project so that our xcodeproj file isn't reliant on the cordova/lib folder existing, and this particular script isn't actually a "lib" in the standard sense.
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 74.58% 74.58%
=======================================
Files 11 11
Lines 1826 1826
=======================================
Hits 1362 1362
Misses 464 464Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
See #540
Description
There didn't seem to be a compelling reason to keep this as JavaScript since it was primarily just shelling out to run various commands. By keeping it in bash, we can significantly simplify the invocation in the xcodeproj file and we can run it without a dependency on shelljs.
I also moved it into a Scripts folder inside the project so that our xcodeproj file isn't reliant on the cordova/lib folder existing, and this particular script isn't actually a "lib" in the standard sense.
Testing
Created a local project with this branch and built the iOS platform both with and without node_modules present.
All automated tests passed locally.
Checklist