CB-8757 - Resolve symlinks in order to avoid relative path issues #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,9 +90,12 @@ plugman.commands = { | |||
| plugman.owner(cli_opts.argv.remain); | |||
| }, | |||
| 'install' : function(cli_opts) { | |||
| resolvePathsInArgs(cli_opts); | |||
There was a problem hiding this comment.
CLI code doesn't pass through here either I don't think. Within install.js is where you should do it I think.
mbektchiev
force-pushed
the
bektchiev/resolve-symlinks-in-paths
branch
from
ed4ec7f
to
ef93888
Compare
|
@agrieve I moved the fixes to |
| @@ -228,3 +228,4 @@ plugman.commands = { | |||
| }; | |||
|
|
|||
| module.exports = plugman; | |||
|
|
|||
There was a problem hiding this comment.
looks good. just revert this unchanged file and fix the one failing test.
mbektchiev
force-pushed
the
bektchiev/resolve-symlinks-in-paths
branch
2 times, most recently
from
81be347
to
107f70c
Compare
mbektchiev
force-pushed
the
bektchiev/resolve-symlinks-in-paths
branch
from
107f70c
to
0e85615
Compare
|
Done. I hadn't noticed the failing test, because it's failing only on Mac, but I hadn't run the tests on a Mac. 🍀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android projects residing in symlinked directories have problems similar to those listen in https://issues.apache.org/jira/browse/CB-8757 for iOS. I am proposing a better fix which is platform-agnostic and normalizes the paths as early as possible.