-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-14148 remove nonsense "www" platform from Cordova listing #620
CB-14148 remove nonsense "www" platform from Cordova listing #620
Conversation
LGTM, though I'd feel better knowing why this was in there in the first place. Could not find out anything about it using blame. 😒 |
@dpogue @stevengill do you have any idea what the |
I do not 😞 |
7aebd79
to
099ce78
Compare
|
||
it('should *not* include nonsense "www" platform (CB-14148)', function () { | ||
expect(platforms.www).not.toBeDefined(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been battling needlessly verbose tests. Would you be OK if we merge the last three tests to the following?
it('should have all and only the supported platforms', function () {
expect(Object.keys(platforms)).toEqual(jasmine.arrayWithExactContents([
'android', 'browser', 'ios', 'osx', 'windows'
]));
});
With that change, I'd approve this PR. I think we should just risk removing the www
platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to incorporate that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I can incorporate the change later today. I would also like this PR to land with a commit message that will indicate what we did to the user in the RELEASENOTES, kinda like the way I updated the title.
Reproduces CB-14148: nonsense "www" platform in platforms object
(now removed)
099ce78
to
d200905
Compare
Now merged with test cases merged as proposed by @raphinesse |
Platforms affected
All
What does this PR do?
cordova platform ls
platforms
objectWhat testing has been done on this change?
cordova-lib
andcordova-cli
projectsnpm test
completely passes (in CI)Checklist