Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14148 remove nonsense "www" platform from Cordova listing #620

Merged
merged 4 commits into from
Aug 15, 2018

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 26, 2018

Platforms affected

All

What does this PR do?

  • Remove nonsense "www" platform from listing in cordova platform ls
  • Verify proper attributes and behavior of platforms object

What testing has been done on this change?

  • Verified that the nonsense "www" member is removed in spec
  • Verified working properly in local copy of cordova-lib and cordova-cli projects
  • Verified that npm test completely passes (in CI)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@raphinesse
Copy link
Contributor

LGTM, though I'd feel better knowing why this was in there in the first place. Could not find out anything about it using blame. 😒

@raphinesse
Copy link
Contributor

@dpogue @stevengill do you have any idea what the www platform's purpose is or was?

@dpogue
Copy link
Member

dpogue commented Jul 12, 2018

I do not 😞

@brodycj brodycj force-pushed the cb-14148-remove-nonsense-www-platform branch from 7aebd79 to 099ce78 Compare August 6, 2018 13:08

it('should *not* include nonsense "www" platform (CB-14148)', function () {
expect(platforms.www).not.toBeDefined();
});
Copy link
Contributor

@raphinesse raphinesse Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been battling needlessly verbose tests. Would you be OK if we merge the last three tests to the following?

it('should have all and only the supported platforms', function () {
    expect(Object.keys(platforms)).toEqual(jasmine.arrayWithExactContents([
        'android', 'browser', 'ios', 'osx', 'windows'
    ]));
});

With that change, I'd approve this PR. I think we should just risk removing the www platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to incorporate that change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I can incorporate the change later today. I would also like this PR to land with a commit message that will indicate what we did to the user in the RELEASENOTES, kinda like the way I updated the title.

@brodycj brodycj changed the title CB-14148 remove nonsense "www" platform from listing CB-14148 remove nonsense "www" platform from Cordova listing Aug 15, 2018
@brodycj brodycj removed the request for review from stevengill August 15, 2018 19:32
@brodycj brodycj force-pushed the cb-14148-remove-nonsense-www-platform branch from 099ce78 to d200905 Compare August 15, 2018 19:48
@brodycj brodycj merged commit bd92683 into apache:master Aug 15, 2018
@brodycj brodycj deleted the cb-14148-remove-nonsense-www-platform branch August 15, 2018 19:52
@brodycj
Copy link
Contributor Author

brodycj commented Aug 15, 2018

Now merged with test cases merged as proposed by @raphinesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants