CB-14148 remove nonsense "www" platform from Cordova listing #620
Conversation
LGTM, though I'd feel better knowing why this was in there in the first place. Could not find out anything about it using blame. |
@dpogue @stevengill do you have any idea what the |
I do not |
7aebd79
to
099ce78
|
||
it('should *not* include nonsense "www" platform (CB-14148)', function () { | ||
expect(platforms.www).not.toBeDefined(); | ||
}); |
raphinesse
Aug 15, 2018
•
Contributor
I've been battling needlessly verbose tests. Would you be OK if we merge the last three tests to the following?
it('should have all and only the supported platforms', function () {
expect(Object.keys(platforms)).toEqual(jasmine.arrayWithExactContents([
'android', 'browser', 'ios', 'osx', 'windows'
]));
});
With that change, I'd approve this PR. I think we should just risk removing the www
platform.
I've been battling needlessly verbose tests. Would you be OK if we merge the last three tests to the following?
it('should have all and only the supported platforms', function () {
expect(Object.keys(platforms)).toEqual(jasmine.arrayWithExactContents([
'android', 'browser', 'ios', 'osx', 'windows'
]));
});
With that change, I'd approve this PR. I think we should just risk removing the www
platform.
brodybits
Aug 15, 2018
Author
Contributor
👍
raphinesse
Aug 15, 2018
Contributor
Do you want to incorporate that change?
Do you want to incorporate that change?
brodybits
Aug 15, 2018
Author
Contributor
Yes I can incorporate the change later today. I would also like this PR to land with a commit message that will indicate what we did to the user in the RELEASENOTES, kinda like the way I updated the title.
Yes I can incorporate the change later today. I would also like this PR to land with a commit message that will indicate what we did to the user in the RELEASENOTES, kinda like the way I updated the title.
4 commits
Jun 26, 2018
and others
added Reproduces CB-14148: nonsense "www" platform in platforms object
(now removed)
099ce78
to
d200905
Now merged with test cases merged as proposed by @raphinesse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Platforms affected
All
What does this PR do?
cordova platform ls
platforms
objectWhat testing has been done on this change?
cordova-lib
andcordova-cli
projectsnpm test
completely passes (in CI)Checklist