Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14017 (android): Make com.android.support:support-v4 version configurable #318

Merged
merged 1 commit into from
May 19, 2018

Conversation

jcesarmobile
Copy link
Member

Platforms affected

Android

What does this PR do?

Creates a variable so users can configure the com.android.support:support-v4 version

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@macdonst macdonst merged commit e334656 into apache:master May 19, 2018
@thienban
Copy link

thienban commented Apr 29, 2019

Hi, i add the cordova-plugin-camera 4.0.3. I want to set 26.1.0 for ANDROID_SUPPORT_V4_VERSION. But I have the ANDROID_SUPPORT_V4_VERSION in 24.1.1. Can you see what to do to add "ANDROID_SUPPORT_V4_VERSION" ?
In config.xml :

    <plugin name="cordova-plugin-camera" spec="4.0.3" source="npm">
        <variable name="CAMERA_USAGE_DESCRIPTION" value="Used to take photos" />
        <variable name="PHOTOLIBRARY_USAGE_DESCRIPTION" value="Used to store photos" />
        <variable name="ANDROID_SUPPORT_V4_VERSION" value="26.1.0" />
    </plugin>

@jcesarmobile jcesarmobile deleted the CB-14017 branch April 29, 2019 08:16
@jcesarmobile
Copy link
Member Author

This doesn’t work on 4.0.3, but a new version has not been released with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants