Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR changes the path counter for a timestamp. The counter was subscribing another paths. #326

Closed
wants to merge 3 commits into from

Conversation

gabrielsscavalcante
Copy link

Platforms affected

iOS

What does this PR do?

This PR changes the path counter for a timestamp. The counter was subscribing another paths.

What testing has been done on this change?

Only used on my application.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are failing

@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-camera",
"version": "4.0.4-dev",
"version": "~4.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks all the tests as it is not a valid version.

@@ -45,7 +45,7 @@
},
"4.1.0": {
"cordova-android": ">=6.3.0",
"cordova": ">=7.1.0"
"cordova": ">=6.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@jcesarmobile
Copy link
Member

this PR did a similar thing #306 and it's merged, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants