-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform Android support for AndroidX #688
Conversation
merge from apache
sieman <- apache
Thanks Siegmar for your PR. We've already discussed AndroidX a bit and it's a tricky decision. On the one hand, if we go for AndroidX and enforce it, we will probably break a lot of plugins. But on the other hand, there might be some changes by Google that forces us to enable AndroidX nevertheless. In the meantime you could use the cordova-plugin-androidx-adapter (which you probably already do). See also apache/cordova-android#841 and the discussion on YT: https://www.youtube.com/watch?v=oarY6ZYj-CU, if interested. |
Any update on when this plugin might move to AndroidX? I'm sure I'm not alone in saying this -- this is now the only remaining plugin my apps use that requires the use of |
|
||
<preference name="ANDROID_SUPPORT_V4_VERSION" default="27.+"/> | ||
<framework src="com.android.support:support-v4:$ANDROID_SUPPORT_V4_VERSION"/> | ||
<preference name="AndroidXEnabled" value="true" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As cordova-android 10 now comes with AndroidX by default those changes aren't really needed. I even got an error while building with the nightly version of cordova-android.
Failed to install 'cordova-plugin-camera': Error: Variable(s) missing: ANDROIDXENABLED
at Object.mergeVariables (/Users/niklasmerz/.nvm/versions/node/v12.14.1/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/variable-merge.js:58:15)
at /Users/niklasmerz/.nvm/versions/node/v12.14.1/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:302:44
at processTicksAndRejections (internal/process/task_queues.js:94:5)
As cordova-android 10 now works only with AndroidX we should move forward with this. |
It was done in #751, closing |
No description provided.