Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(android): clarify documentation and types for sdkVersion field #174

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

peitschie
Copy link
Contributor

Platforms affected

Android only

Motivation and Context

Aligning documentation and types! Nothin' special...

Description

As above

Testing

Have confirmed the types work locally for me. No other code changes.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@peitschie peitschie changed the title Correct type and clarify documentation for sdkVersion field doc(android): clarify documentation and types for sdkVersion field Jul 7, 2022
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NiklasMerz NiklasMerz merged commit 901bd8a into apache:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants