Allowing chunkedMode to be false on Android with uploads over https #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpal
changed the title
|
Can one of the admins verify this patch? |
|
I ran into this issue while testing my app on an Android device as well. I modified the code similar to this PR and things work like they should. Please don't overwrite the chunkedMode setting that is being passed in from the JS side. |
|
I wasn't able to receive files in a PHP FastCGI server due it did not allowed chunkedMode if you were over HTTPS. With this patch it works now. |
|
This can be closed, right? 6554899 |
|
With the new features introduced in XMLHttpRequest, this plugin is not needed any more. Migrating from this plugin to using the new features of XMLHttpRequest, is explained in this Cordova blog post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
File uploads over https were automatically turned to Transfer-encoding: chunked due to old Android issues. Since adding this header to transfers often breaks functionality (for example you can't add an additional header to an Amazon S3 request that was signed without it) - isn't it better to follow the users instruction to use chunked mode or not instead of overwriting it?
What testing has been done on this change?
Only deployed on one Android device, can not verify that it doesn't cause OOM issues - but this option is available as a setting for the user to controll in js.
Checklist