test(spec.timeout): try to improve against timeout failures #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlingel
pushed a commit
to schlingel/cordova-plugin-media
that referenced
this pull request
Oct 25, 2023
* test(spec.timeout): improve safe complete for before and after each spec * test(spec.timeout): add done to success callback * test(spec.timeout): set DEFAULT_TIMEOUT_INTERVAL to ACTUAL_PLAYBACK_TEST_TIMEOUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
test
Motivation and Context
GH Actions CI appears to hit timeout limits.
Description
I made sure the done function was called in success callback, if called, objects cleared in both before and after each, and set the jasmine default timeout to match against the playback test timeout.
Testing
Manual and GH Actions:
Checklist
(platform)if this change only applies to one platform (e.g.(android))