fix(mango): integration tests #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- They do not check the count of the returned documents but blindly assume that there will be results. Add an explicit assertion about the expected number of documents in the response so it could be detected if something breaks. - The assertion on the document count revealed that the test database is actually empty because it is immediately wiped out after creation by a misplaced `recreate()` call. - When the indexing on the array lengths is disabled, there shall be no documents returned, and not the sizes of the `favorites` arrays in the results shall be zero. That is because there is no information available on the sizes of the arrays.
The result of the `mango.has_text_service()` checks is implicitly forecasted by the `@unittest.skipUnless` annotations in the head of the class declaration. Hence they are not needed anymore.
jaydoane
approved these changes
May 21, 2023
There was a problem hiding this comment.
Nice fixes!
running clouseau c59127d5657e3130b55d6e2b9575820a08e438e1
make mango-test
[ * ] Exec command COUCH_USER=adm COUCH_PASS=pass .venv/bin/python3 -m nose2 ... ........s.ss.s.s.............s.ss.s.s............s.ss.s.s.............................................................................................................................................................s...................................................................................................................................................
----------------------------------------------------------------------
Ran 362 tests in 25.601s
OK (skipped=16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the faulty
index_array_lengthtests:They do not check the count of the returned documents but blindly
assume that there will be results. Add an explicit assertion about
the expected number of documents in the response so it could be
detected if something breaks.
The assertion on the document count revealed that the test database
is actually empty because it is immediately wiped out after creation
by a misplaced
recreate()call.When the indexing on the array lengths is disabled, there shall be no
documents returned, and not the sizes of the
favoritesarrays inthe results shall be zero. That is because there is no information
available on the sizes of the arrays.
The result of the
mango.has_text_service()checks is implicitly forecasted by the@unittest.skipUnlessannotations in the head of the class declaration. Hence they are not needed anymore.