[CXF-9023] Increase unit test coverage on org.apache.cxf.bus #1901
Conversation
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| public class ManagedBusTest { |
There was a problem hiding this comment.
@jgoodyear the ManagedBus is covered by ManagedBusTest (systests/uncategorized)
There was a problem hiding this comment.
Feels odd to have classes tested outside of the package, even to have some basic smoke testing.
There was a problem hiding this comment.
CXF is quite old and some decisions as well, but we should not add tests for a sake of tests or/and coverage, it adds significant maintenance costs for no benefits (surely, in context of CXF).
There was a problem hiding this comment.
Right on.
Shall CXF-9023 & CXF-9024 be closed as 'will not fix'?
There was a problem hiding this comment.
If you don't mind, let's spend some time and find the gaps, fe. I have not found any tests for ClientLifeCycleManagerImpl but you added one (thank again for it), there could be others
There was a problem hiding this comment.
Take any portion of the PR you see value in retaining :)
|
@jgoodyear thanks for working on tests, I believe we should spend a bit more time on crafting more or less realistic test cases, may be under |
* [CXF-9023] Increase unit test coverage on org.apache.cxf.bus * Remove the tests for classes that already have enough coverage --------- Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 59bc6c2)
No description provided.