CXF-9055 Follow OpenTelemetry semconv for trace span and its attributes #2062

csemaan1A · 2024-09-11T16:09:52Z

Add missing span attributes to comply with OpenTelemetry semantic conventions
Test the span attribute names and values
Couldn't add the attributes "network.protocol.version" for the client http span, because we didn't find a way to find its value.

Link to the Jira ticket: CXF-9055 Follow OpenTelemetry semantic conventions for trace span and its attributes

.../src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java

reta · 2024-09-11T17:56:13Z

Thanks for the pull request, @csemaan1A ! I would suggest to preserve the span name (as you highlighted, it is breaking) to have consistent behavior across CXF tracing integrations, thank you.

csemaan1A · 2024-09-12T07:21:44Z

Thanks for the pull request, @csemaan1A ! I would suggest to preserve the span name (as you highlighted, it is breaking) to have consistent behavior across CXF tracing integrations, thank you.

I renamed it to have only the path to be aligned with the semantic convention of OpenTelemetry.

Keep in mind, that the server span name is set to path, not the full URL.
So what do you think?

reta · 2024-09-12T11:55:29Z

I renamed it to have only the path to be aligned with the semantic convention of OpenTelemetry.

Thanks, I read the recommendations and I don't see much of controversy here. Yes, the span name has more than path (too specific?) but what is more important - we are not adding blank implementation. I would prefer to not break things.

.../src/main/java/org/apache/cxf/tracing/opentelemetry/OpenTelemetryClientStartInterceptor.java

integration/tracing/tracing-opentelemetry/pom.xml

...emetry/src/main/java/org/apache/cxf/tracing/opentelemetry/OpenTelemetryStartInterceptor.java

...elemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/jaxrs/OpenTelemetryProvider.java

* Add missing span attributes to comply with [OpenTelemetry semantic conventions](https://opentelemetry.io/docs/specs/semconv/http/http-spans/) * Test the span attribute names and values * Couldn't add the attributes "network.protocol.version" for the client http span, because we didn't find a way to find its value. Link to the Jira ticket: [CXF-9055 Follow OpenTelemetry semantic conventions for trace span and its attributes ](https://issues.apache.org/jira/browse/CXF-9055)

reta · 2024-09-13T21:26:40Z

Thanks a lot @csemaan1A !

…es (#2062) * Add missing span attributes to comply with [OpenTelemetry semantic conventions](https://opentelemetry.io/docs/specs/semconv/http/http-spans/) * Test the span attribute names and values * Couldn't add the attributes "network.protocol.version" for the client http span, because we didn't find a way to find its value. Link to the Jira ticket: [CXF-9055 Follow OpenTelemetry semantic conventions for trace span and its attributes ](https://issues.apache.org/jira/browse/CXF-9055) (cherry picked from commit 1f0355e)

…es (#2062) * Add missing span attributes to comply with [OpenTelemetry semantic conventions](https://opentelemetry.io/docs/specs/semconv/http/http-spans/) * Test the span attribute names and values * Couldn't add the attributes "network.protocol.version" for the client http span, because we didn't find a way to find its value. Link to the Jira ticket: [CXF-9055 Follow OpenTelemetry semantic conventions for trace span and its attributes ](https://issues.apache.org/jira/browse/CXF-9055) (cherry picked from commit 1f0355e) (cherry picked from commit 9be1640) # Conflicts: # integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/jaxrs/OpenTelemetryProvider.java

…es (#2062) * Add missing span attributes to comply with [OpenTelemetry semantic conventions](https://opentelemetry.io/docs/specs/semconv/http/http-spans/) * Test the span attribute names and values * Couldn't add the attributes "network.protocol.version" for the client http span, because we didn't find a way to find its value. Link to the Jira ticket: [CXF-9055 Follow OpenTelemetry semantic conventions for trace span and its attributes ](https://issues.apache.org/jira/browse/CXF-9055) (cherry picked from commit 1f0355e) (cherry picked from commit 9be1640) # Conflicts: # integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/jaxrs/OpenTelemetryProvider.java (cherry picked from commit 7a15456)

reta reviewed Sep 11, 2024

View reviewed changes

.../src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java Outdated Show resolved Hide resolved

csemaan1A force-pushed the add-semantic-convention-attributes branch from 0536ce2 to 31a3bb2 Compare September 12, 2024 09:07

csemaan1A force-pushed the add-semantic-convention-attributes branch from 31a3bb2 to 21a1fcc Compare September 12, 2024 12:39