Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typesafe:config to 1.4.3 #1096

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates com.typesafe:config from 1.4.2 to 1.4.3

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.typesafe", artifactId = "config" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.typesafe", artifactId = "config" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Copy link
Member

@stevedlawrence stevedlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Interestingly, this line was added to the README:

The "Typesafe Config" library is an important foundation to how Akka and other JVM libraries manage configuration. We at Lightbend consider the functionality of this library as feature complete. We will make sure "Typesafe Config" keeps up with future JVM versions, but will rarely make any other changes.

This library isn't a big part of Daffodil, so lack of updates isn'ta big deal. But if that ever changes and some updates are needed we may need to consider a different library. Especially considering there are over 200 issues that will presumably will never be resolved. Looks like there was even discussion about a community fork: lightbend/config#789

  • Do all automated continuous integration checks pass?
    Yes
  • Is the update a patch, minor, or major update?
    Patch update, mostly doc fixes, one feature related to hiding env vars, does not affect daffodil
  • Is the license still compatible with ASF License Policy?
    Yes, still Apache 2.0 license
  • Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
    No changes
  • Have any transitive dependencies been added or changed?
    No

Copy link
Contributor

@tuxji tuxji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tuxji tuxji merged commit 1c5e5fe into apache:main Nov 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants