-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DataFusion cli/repl to own crate #218
Comments
+1 these cli dependencies could cause unnecessary dependency conflicts for downstream datafusion consumers as well. |
That's a good one @houqp I'll add that as well. |
I think this is a good idea. We might even get away without publishing the cli as a separate crate unless we have people who use it (perhaps we can pull the binary out and then publish a new crate if anyone wants it) |
I also filed apache/datafusion-ballista#455 for publishing the DataFusion CLI as a Docker image |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The Datafusion cli/repl functionality now lives inside the DataFusion tree.
This has two main implications:
clap
rustyline
and transitive dependencies) unneeded for the rest of DataFusion, slowing the development cycle down a bit (mainly for clean builds).cargo install datafusion --bin datafusion-cli --release
Describe the solution you'd like
Move the
datafusion-cli
to the root dir.Publish the crate to
crates.io
asdatafusion-cli
. The tool now can be installed usingcargo install datafusion-cli --release
and now lives outside of the DataFusion crate.Describe alternatives you've considered
Keep structure as is.
Additional context
The text was updated successfully, but these errors were encountered: