Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DataFusion cli/repl to own crate #218

Closed
Dandandan opened this issue Apr 28, 2021 · 4 comments · Fixed by #231
Closed

Move DataFusion cli/repl to own crate #218

Dandandan opened this issue Apr 28, 2021 · 4 comments · Fixed by #231
Labels
enhancement New feature or request

Comments

@Dandandan
Copy link
Contributor

Dandandan commented Apr 28, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The Datafusion cli/repl functionality now lives inside the DataFusion tree.
This has two main implications:

  • Building DataFusion fetches extra dependencies (clap rustyline and transitive dependencies) unneeded for the rest of DataFusion, slowing the development cycle down a bit (mainly for clean builds).
  • Installing the binary using cargo is a bit more cumbersome, cargo install datafusion --bin datafusion-cli --release
  • dependency constraints on the cli dependencies potentially can cause conflicts for DataFusion consumers

Describe the solution you'd like
Move the datafusion-cli to the root dir.
Publish the crate to crates.io as datafusion-cli. The tool now can be installed using cargo install datafusion-cli --release and now lives outside of the DataFusion crate.

Describe alternatives you've considered
Keep structure as is.

Additional context

@Dandandan Dandandan added the enhancement New feature or request label Apr 28, 2021
@Dandandan Dandandan changed the title Move DataFusion cli/repl to own Move DataFusion cli/repl to own crate Apr 28, 2021
@houqp
Copy link
Member

houqp commented Apr 28, 2021

+1 these cli dependencies could cause unnecessary dependency conflicts for downstream datafusion consumers as well.

@Dandandan
Copy link
Contributor Author

That's a good one @houqp I'll add that as well.

@alamb
Copy link
Contributor

alamb commented Apr 30, 2021

I think this is a good idea. We might even get away without publishing the cli as a separate crate unless we have people who use it (perhaps we can pull the binary out and then publish a new crate if anyone wants it)

@andygrove
Copy link
Member

I also filed apache/datafusion-ballista#455 for publishing the DataFusion CLI as a Docker image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants