Minor: Add example for configuring SessionContext #12139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 23, 2024
| @@ -19,6 +19,8 @@ | |||
|
|
|||
| pub mod context; | |||
| pub mod session_state; | |||
| pub use session_state::{SessionState, SessionStateBuilder}; | |||
There was a problem hiding this comment.
this makes it possible to do
use datafusion::execution::SessionStateBuilder;
alamb
commented
Aug 23, 2024
| @@ -1427,6 +1461,12 @@ impl From<&SessionContext> for TaskContext { | |||
| } | |||
| } | |||
|
|
|||
| impl From<SessionState> for SessionContext { | |||
There was a problem hiding this comment.
This makes it possible to do
let ctx = SessionContext::from(state);
|
lgtm, thanks for adding this |
alamb
changed the title
comphead
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While working on the reprpoducer for #12136 I knew there was a nice builder API added by @Omega359 in #11403 but I couldn't find it quickly in the docs
What changes are included in this PR?
pub useforSessionStateBuilderFromimpl for SessionState to make the example nicerAre these changes tested?
yes, by doc CI
Are there any user-facing changes?
Yes, the changes are user facing
here is what the new docs look like