Support Date32 for date_trunc function
#12603
Merged
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Sep 24, 2024
| @@ -123,7 +123,9 @@ impl ScalarUDFImpl for DateTruncFunc { | |||
|
|
|||
| fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> { | |||
| match &arg_types[1] { | |||
| Timestamp(Nanosecond, None) | Utf8 | Null => Ok(Timestamp(Nanosecond, None)), | |||
| Timestamp(Nanosecond, None) | Utf8 | DataType::Date32 | Null => { | |||
There was a problem hiding this comment.
I also tried to support Date64 but got many type coercion issues between Timestamp and Date64. I think we should handle them in another PR if needed.
alamb
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Looks good to me -- thank you for the contribution @goldmedal
|
Thanks @alamb 🙇 |
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12602 .
Rationale for this change
What changes are included in this PR?
date_truncacceptsDate32now.Are these changes tested?
yes
Are there any user-facing changes?
no