Fix to unparse the plan with multiple UNION statements into an SQL string #12605
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
changed the title
phillipleblanc
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks @goldmedal! One minor comment on the error message, but otherwise looks good to me! I should have tested more than 2 UNIONs initially 😅
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
phillipleblanc
approved these changes
Sep 25, 2024
alamb
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Looks good to me -- thank you @goldmedal and @phillipleblanc for the review
|
Thanks @alamb @phillipleblanc ! |
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
…ring (apache#12605) * fix unparse multiple UNION statement * enhance the error message Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> * cargo fmt --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
sgrebnov
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Oct 1, 2024
…ring (apache#12605) * fix unparse multiple UNION statement * enhance the error message Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> * cargo fmt --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
sgrebnov
added a commit
to spiceai/datafusion
that referenced
this pull request
Oct 1, 2024
…ring (apache#12605) (#37) * fix unparse multiple UNION statement * enhance the error message * cargo fmt --------- Co-authored-by: Jax Liu <liugs963@gmail.com> Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No corrsponding issue.
Rationale for this change
Consider the following SQL:
WITH w1 AS (SELECT 'a' as col), w2 AS (SELECT 'b' as col), w3 as (SELECT 'c' as col) SELECT * FROM w1 UNION ALL SELECT * FROM w2 UNION ALL SELECT * FROM w3If a plan contains more than two UNION statements, it cannot be properly unparsed back into an SQL string.
What changes are included in this PR?
Fix the unparsing behavior for UNION.
Are these changes tested?
yes
Are there any user-facing changes?
no