Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed requirement of JIRA to PRs. #14

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

jorgecarleitao
Copy link
Member

So that the bot does not comment on every PR that a JIRA issue is missing.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #14 (a1742fc) into master (4123600) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   70.41%   70.41%           
=======================================
  Files         123      123           
  Lines       21261    21261           
=======================================
  Hits        14970    14970           
  Misses       6291     6291           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4123600...a1742fc. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Apr 20, 2021

I rewrote master to remove the history of the other languages (and 50MB of history). This means this PR will need to be "rebased" against the current master.

The best way I found to do this was to find the relevant commits (via git log) and then cherry-pick them one at a time. For example (change COMMIT-SHA to whatever the commit actually is):

git reset --hard apache/master
git cherry-pick COMMIT-SHA
git push -f your_rep

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 2c4d2dc

@alamb
Copy link
Contributor

alamb commented Apr 20, 2021

I am going to try and rebase this PR

@alamb alamb merged commit 7136cad into apache:master Apr 20, 2021
@houqp houqp added the development-process Related to development process of DataFusion label Jul 29, 2021
yjshen referenced this pull request in yjshen/datafusion Dec 27, 2021
* wip

* make cargo test compile
EricJoy2048 pushed a commit to argoengine/arrow-datafusion that referenced this pull request Feb 24, 2022
使用单例的datafusion execution context解决每个sql完成后元数据被重置的问题

Closes apache#14

See merge request noah/argo_engine!37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants