Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression for push_down_filter meet subquery-alias #4384

Closed

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Nov 26, 2022

Which issue does this PR close?

Closes #4381 .

Rationale for this change

It will resolve regression problem in #4333

What changes are included in this PR?

  • push_down_filter support subqueryAlias
  • push_down_limit support subqueryAlias

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner labels Nov 26, 2022
@jackwener
Copy link
Member Author

jackwener commented Nov 26, 2022

Now, this PR has merge #4333, because it depends on it.
Wait for it.

@github-actions github-actions bot removed sql SQL Planner logical-expr Logical plan and expressions labels Nov 29, 2022
@jackwener jackwener changed the title rule support subquery alias fix regression for push_down_filter meet subquery-alias Nov 29, 2022
@jackwener jackwener closed this Nov 29, 2022
@jackwener jackwener deleted the rule_support_subquery_alias branch December 6, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimizer rule support subqueryAlias
1 participant