-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5500 - Add a GitHub Actions workflow that builds the docs #5670
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
This PR is a follow up of #5631 Last successful run of the new |
TODOs for the Datafusion committers:
|
Done. |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
I tested this PR out in my fork and it works great! Thank you @martin-g Here https://github.com/alamb/arrow-datafusion/tree/asf-site What are the next steps after this PR to actually get this site served? On my fork I configured github pages: And it published https://github.com/alamb/arrow-datafusion/actions/runs/4483635485 which is cool But the site looks pretty bad https://alamb.github.io/arrow-datafusion |
Here is a PR to do this apache/arrow-site#336 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
ASF provides https://arrow.apache.org/ (not GitHub Pages) that serves the contents in https://github.com/apache/arrow-site/tree/asf-site . |
…support Suggested-by @kou at apache#5670 (comment) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
I tested the latest and greatest code on my fork and it seems to have worked great! https://alamb.github.io/arrow-datafusion/ Thank you so much @martin-g and @kou I am going to merge this PR and see how it goes! |
I am happy to report that the first run of https://github.com/apache/arrow-datafusion/actions/runs/4488868585/jobs/7893990469 has worked And the content appears to be on https://github.com/apache/arrow-datafusion/tree/asf-site 👍 I am going to test making changes to the datafusion site and verify they appear on https://arrow.apache.org/datafusion/ |
My test shows that the process is working : #5500 (comment) |
PR to update release process: #5687 |
@@ -1,7 +1,4 @@ | |||
|
|||
<a class="navbar-brand" href="{{ pathto(master_doc) }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a proposal to get the logo back : #5688
Which issue does this PR close?
Closes #5500
Rationale for this change
Deploy the Datafusion website whenever a change is made in the
docs/
folder.What changes are included in this PR?
A new Github Action is introduced that builds the docs and copies them to
asf-site
branchAre these changes tested?
Yes, I have tested them in my fork.
Are there any user-facing changes?
No