Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataFusion architecture documentation #6056

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 19, 2023

Which issue does this PR close?

Closes #5501

Rationale for this change

I am trying to make it easier to work on and use the DataFusion project

What changes are included in this PR?

  1. Update the architecture guide

Are these changes tested?

No (though the links are verified by the changes in #6044)

Are there any user-facing changes?

Better docs

Here is an example:

Screenshot 2023-04-20 at 8 17 25 AM

@github-actions github-actions bot added the core Core DataFusion crate label Apr 19, 2023
@alamb alamb force-pushed the alamb/execution_docs branch 2 times, most recently from d9f1f31 to 275d6f2 Compare April 19, 2023 13:09
@alamb alamb added the documentation Improvements or additions to documentation label Apr 20, 2023
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 20, 2023
@alamb alamb added documentation Improvements or additions to documentation development-process Related to development process of DataFusion labels Apr 20, 2023
@alamb alamb marked this pull request as ready for review April 20, 2023 12:17
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

datafusion/core/src/datasource/empty.rs Outdated Show resolved Hide resolved
datafusion/core/src/datasource/empty.rs Outdated Show resolved Hide resolved
Copy link
Member

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

datafusion/core/src/lib.rs Outdated Show resolved Hide resolved
datafusion/core/src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: comphead <comphead@users.noreply.github.com>
Co-authored-by: Yang Jiang <jiangyang381@163.com>
@github-actions github-actions bot removed development-process Related to development process of DataFusion documentation Improvements or additions to documentation labels Apr 21, 2023
@alamb alamb merged commit 85afd4b into apache:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the docs for developers (Create a Developers / Hackers guide for DataFusion)
3 participants