Update arrow 48.0.0 #7854
Merged
Update arrow 48.0.0 #7854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
prepare-arrow-48
branch
from
d9eaf33
to
f4a4985
Compare
tustvold
force-pushed
the
prepare-arrow-48
branch
from
f4a4985
to
30d3269
Compare
tustvold
commented
Oct 18, 2023
| @@ -58,8 +58,10 @@ AggregateExec: mode=Final, gby=[], aggr=[COUNT(*)] | |||
| ------RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 | |||
| --------JsonExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/core/tests/data/2.json]]}, projection=[a] | |||
|
|
|||
| query error DataFusion error: Schema error: No field named mycol\. | |||
| query ? | |||
There was a problem hiding this comment.
alamb
reviewed
Oct 18, 2023
| @@ -37,13 +37,6 @@ pub struct CsvWriterOptions { | |||
| /// Compression to apply after ArrowWriter serializes RecordBatches. | |||
| /// This compression is applied by DataFusion not the ArrowWriter itself. | |||
| pub compression: CompressionTypeVariant, | |||
| /// Indicates whether WriterBuilder.has_header() is set to true. | |||
4 tasks
crepererum
approved these changes
Oct 23, 2023
tustvold
force-pushed
the
prepare-arrow-48
branch
from
3a28d98
to
f16fa15
Compare
viirya
reviewed
Oct 23, 2023
Comment on lines
-82
to
-90
| "rfc3339" => { | ||
| let value_bool = value.parse() | ||
| .map_err(|_| DataFusionError::Configuration(format!("Unable to parse {value} as bool as required for {option}!")))?; | ||
| if value_bool{ | ||
| builder.with_rfc3339() | ||
| } else{ | ||
| builder | ||
| } | ||
| }, |
viirya
approved these changes
Oct 23, 2023
viirya
reviewed
Oct 23, 2023
| @@ -523,9 +523,9 @@ mod tests { | |||
|
|
|||
| let csv_options = CsvWriterOptions::try_from((&config, &options))?; | |||
| let builder = csv_options.writer_options; | |||
| assert!(builder.header()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?