-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid concat in array_append
#8137
Avoid concat in array_append
#8137
Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jayzhan211, looks good
Wondering if you can provide some numbers on how performance changed with the new method?
You can create a small local benchmark on zillions of values to check before and after.
This comment was marked as outdated.
This comment was marked as outdated.
unit: millis Single Row
Two Row
|
Thanks @jayzhan211 |
Single row is like [[1,2,3]] or ListArray( Int64Array(1,2,3) ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jayzhan211
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jayzhan211 and @comphead -- this is so nice. It will be amazing if you could apply the same transformation to the rest of the functions in this module
values, | ||
None, | ||
)?) | ||
return general_append_and_prepend( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which issue does this PR close?
Follow up on #8108 (review)
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?