Fix Display for List #8261
Merged
Fix Display for List #8261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayzhan211
commented
Nov 18, 2023
datafusion/common/src/scalar.rs
Outdated
| )?, | ||
| ScalarValue::List(arr) | ScalarValue::FixedSizeList(arr) => { | ||
| // TODO: Remove NullArray | ||
| // There are NullArray(0) currently, so we need to check the length |
There was a problem hiding this comment.
We may file an ticket to track it
alamb
reviewed
Nov 20, 2023
datafusion/common/src/scalar.rs
Outdated
| write!(f, "[]")? | ||
| } else { | ||
| let options = FormatOptions::default().with_display_error(true); | ||
| // TODO: No way to map to fmt::Error yet |
There was a problem hiding this comment.
https://docs.rs/arrow/latest/arrow/util/display/struct.ArrayFormatter.html#method.try_new says it returns an error if the type can't be formatted. Since this code knows that it is always a ListArray I think it would be ok to simply unwrap the error (ArrayFormatter::try_new(...).unwrap())
alamb
reviewed
Nov 20, 2023
7 tasks
|
Continue on this after |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
force-pushed
the
display-list
branch
from
42b8939
to
6727b92
Compare
alamb
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8259.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?