Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: replace not-impl-err in array_expression #8589

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Minor: replace not-impl-err in array_expression #8589

merged 1 commit into from
Dec 20, 2023

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Dec 19, 2023 •
edited
Loading

Which issue does this PR close?

In #8569 (comment)_, the error output should be consistent for unsupported type.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Dec 19, 2023
comphead
comphead approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @Weijun-H for the follow up

@comphead comphead merged commit b925b78 into apache:main Dec 20, 2023
23 checks passed
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comphead comphead comphead approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weijun-H @comphead