Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

prepend deltacould path to prevent errors on require #3

Closed
wants to merge 1 commit into from

Conversation

avalanche123
Copy link

This is the reason for the patch:

deltacloudd -l

/Users/bulat/.rvm/rubies/ruby-1.8.7-p352/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require': no such file to load -- server.rb (LoadError)
    from /Users/bulat/.rvm/rubies/ruby-1.8.7-p352/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
    from /Users/bulat/.rvm/gems/ruby-1.8.7-p352/gems/deltacloud-core-0.4.1/bin/deltacloudd:115
    from /Users/bulat/.rvm/gems/ruby-1.8.7-p352/bin/deltacloudd:19:in `load'
    from /Users/bulat/.rvm/gems/ruby-1.8.7-p352/bin/deltacloudd:19

@avalanche123
Copy link
Author

Hey guys can you please review this?

@marios
Copy link
Contributor

marios commented Oct 26, 2011

Hi - sorry for the delay - looks like we haven't checked the github page for a few days - for future its best to also send an email to deltacloud-dev@incubator.apache.org when you issue a pull request (see http://incubator.apache.org/deltacloud/contact.html)

Does your patch fix the issue for you (looks like you're using Windows right?). It doesn't seem to fix it for me under Fedoara - I'll look into this and let you know - thanks for flagging the problem,

marios

@marios
Copy link
Contributor

marios commented Oct 26, 2011

no idea why i thought that was windows - the paths above look more like Mac OS? (doesn't make a difference, just out of curiosity)

@marios
Copy link
Contributor

marios commented Oct 26, 2011

Hi Bulat, thanks for taking the time to let us know about this issue - the issue was fixed with a minor addition to your patch and is now committed into the apache repo - if you make a pull request you should get the fix.

Closing the pull request.

@avalanche123
Copy link
Author

Thanks

@avalanche123
Copy link
Author

this is still not fixed in version 0.4.1:

bulat@Bulat-Shakirzyanovs-MacBook-Pro:~$ gem search deltacloud

*** LOCAL GEMS ***

deltacloud-core (0.4.1)
bulat@Bulat-Shakirzyanovs-MacBook-Pro:~$ deltacloudd -l
/Users/bulat/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:55:in `require': cannot load such file -- server.rb (LoadError)
    from /Users/bulat/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:55:in `require'
    from /Users/bulat/.rvm/gems/ruby-1.9.3-p0/gems/deltacloud-core-0.4.1/bin/deltacloudd:115:in `<top (required)>'
    from /Users/bulat/.rvm/gems/ruby-1.9.3-p0/bin/deltacloudd:19:in `load'
    from /Users/bulat/.rvm/gems/ruby-1.9.3-p0/bin/deltacloudd:19:in `<main>'

offending lines (114, 115):

if options[:drivers]
  require 'server.rb'

to fix, I changed line 115 to

  require File.dirname(__FILE__)+'/../server.rb'

still more fixes are necessary as for example lib/deltacloud/base_driver/base_driver.rb contains

require 'lib/deltacloud/base_driver/exceptions'

which should be

require 'deltacloud/base_driver/exceptions'

@avalanche123 avalanche123 reopened this Nov 12, 2011
@avalanche123
Copy link
Author

nevermind, I think this is because the gem needs to be updated as the code there is different from sources here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants