Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16308] Fix query resources list paging error and docs. #16324

Merged
merged 7 commits into from
Jul 17, 2024

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

close #16308

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 16, 2024
@SbloodyS SbloodyS added the bug Something isn't working label Jul 16, 2024
RemoteIterator<LocatedFileStatus> remoteIterator = fs.listFiles(new Path(absolutePath), true);
Path path = new Path(absolutePath);
if (!fs.exists(path)) {
return result;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue is better.

Suggested change
return result;
continue;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

sonarcloud bot commented Jul 17, 2024

@SbloodyS SbloodyS merged commit 3dbfac3 into apache:dev Jul 17, 2024
64 checks passed
@SbloodyS SbloodyS deleted the fix_16308 branch July 17, 2024 04:09
@zhang-dz
Copy link

不显示UDF
创建文件夹失败
为什么我按照你说的去做没有修复问题,我重申一遍我的问题,Windows11启动idea拉取3.2.2版本的源码,通过D:\Ideaproject\dolphinscheduler-dao\src\main\resources\sql\dolphinscheduler_mysql.sql配置dolphinscheduler数据库,修改Api、Master、tool的数据库密码和账号,然后mvn package,然后打开zookeeper启动Api、Master,启动前端npm run dev,访问localhost:5173就出现了上面的问题。
Why didn't I fix the problem by following what you said? I'll reiterate my question, Windows 11 start idea pulls the source code of version 3.2.2, through D:\Ideaproject\dolphinscheduler-dao\src\main\resources\sql\ dolphinscheduler_mysql.sql configure the dolphinscheduler database, change the database password and account of Api, Master, tool, and then mvn package, then open zookeeper to start Api, Master, and start UI npm run dev, access the localhost:5173 and the above problem occurs.

@zhang-dz
Copy link

其实它创建成功了,我打开D盘发现这个文件是存在的,D:\tmp\dolphinscheduler\default\resources\test7。
It actually created successfully, I opened the D drive and found that the file exists, D:\tmp\dolphinscheduler\default\resources\test7.

@SbloodyS
Copy link
Member Author

Currently DS does not support running on Windows. @zhang-dz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Doc] query resources list paging&UDF management not displayed
5 participants