Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-60][Http task plugin] Refactor http task plugin #16413

Merged
merged 24 commits into from
Aug 6, 2024

Conversation

SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Aug 2, 2024

Purpose of the pull request

close #16404

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the CI&CD label Aug 2, 2024
@github-actions github-actions bot removed the CI&CD label Aug 2, 2024
caishunfeng
caishunfeng previously approved these changes Aug 6, 2024
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.4% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gallardot Gallardot merged commit a650441 into apache:dev Aug 6, 2024
63 of 65 checks passed
@SbloodyS SbloodyS deleted the dsip_60 branch August 7, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document DSIP e2e e2e test test UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-60][Http task plugin] Refactor http task plugin
5 participants