-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-60][Http task plugin] Refactor http task plugin #16413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
requested review from
EricGao888,
songjianet,
Amy0104,
caishunfeng,
zhuangchong,
Gallardot and
ruanwenjun
as code owners
August 2, 2024 02:38
github-actions
bot
added
UI
ui and front end related
backend
test
e2e
e2e test
document
labels
Aug 2, 2024
...scheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpTask.java
Dismissed
Show dismissed
Hide dismissed
caishunfeng
reviewed
Aug 4, 2024
...ler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParameters.java
Show resolved
Hide resolved
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-http.ts
Outdated
Show resolved
Hide resolved
...nscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoginController.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/apache/dolphinscheduler/common/model/OkHttpRequestHeaderContentType.java
Show resolved
Hide resolved
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OkHttpUtils.java
Show resolved
Hide resolved
ruanwenjun
reviewed
Aug 5, 2024
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OkHttpUtils.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OkHttpUtils.java
Show resolved
Hide resolved
...ler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParameters.java
Show resolved
Hide resolved
dolphinscheduler-standalone-server/src/main/resources/logback-spring.xml
Outdated
Show resolved
Hide resolved
caishunfeng
previously approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ruanwenjun
approved these changes
Aug 6, 2024
Quality Gate failedFailed conditions |
songjianet
approved these changes
Aug 6, 2024
Gallardot
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16404
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md