Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: send task result to master until success. #2839

Merged
merged 5 commits into from
May 29, 2020
Merged

fix bug: send task result to master until success. #2839

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18a5d40
fix bug: send task result to master until success.
May 28, 2020
e6f4002
fix bug: send task result to master until success.
May 28, 2020
e3c1402
add sleep
May 28, 2020
f5c7c6f
set null if send result failed
May 29, 2020
9d7b2d5
set null if send result failed
May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions ...rc/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,23 @@ private NettyRemoteChannel getRemoteChannel(int taskInstanceId){
while (Stopper.isRunning()) {
masterNodes = zookeeperRegistryCenter.getMasterNodesDirectly();
if (CollectionUtils.isEmpty(masterNodes)) {
masterNodes = null;
ThreadUtils.sleep(SLEEP_TIME_MILLIS);
}else {
logger.error("find {} masters for task : {}.",
masterNodes.size(),
taskInstanceId);
break;
continue;
}
}
for(String masterNode : masterNodes){
newChannel = nettyRemotingClient.getChannel(Host.of(masterNode));
if(newChannel != null){
return getRemoteChannel(newChannel, nettyRemoteChannel.getOpaque(), taskInstanceId);
logger.info("find {} masters for task : {}.",
masterNodes.size(),
taskInstanceId);
for (String masterNode : masterNodes) {
newChannel = nettyRemotingClient.getChannel(Host.of(masterNode));
if (newChannel != null) {
return getRemoteChannel(newChannel, nettyRemoteChannel.getOpaque(), taskInstanceId);
}
}
masterNodes = null;
ThreadUtils.sleep(SLEEP_TIME_MILLIS);
}

throw new IllegalStateException(String.format("all available master nodes : %s are not reachable for task: {}", masterNodes, taskInstanceId));
}

Expand Down