Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix-4054][Api] Fix The last week of the month for adding/editing timing, preview and save timing will report an error #4081

Merged
merged 1 commit into from
Nov 19, 2020
Merged

[Fix-4054][Api] Fix The last week of the month for adding/editing timing, preview and save timing will report an error #4081

merged 1 commit into from
Nov 19, 2020

Conversation

iyeeku
Copy link
Contributor

@iyeeku iyeeku commented Nov 18, 2020 •
edited by CalvinKirs
Loading 

this.weekValue = `?`
this.dayValue = val

change to

this.weekValue =val
this.dayValue = `?`

this closes #4054

@iyeeku
[Fix-4054][Api] Fix The last week of the month for adding/editing tim…
9232c0e 
…ing, preview and save timing will report an error
@iyeeku iyeeku mentioned this pull request Nov 18, 2020
Closed
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CalvinKirs CalvinKirs added first time contributor First-time contributor UI ui and front end related labels Nov 19, 2020
@xingchun-chen xingchun-chen added this to the 1.3.4-release milestone Nov 19, 2020
xingchun-chen
xingchun-chen approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@xingchun-chen xingchun-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

break60
break60 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@break60 break60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xingchun-chen xingchun-chen merged commit f152cae into apache:dev Nov 19, 2020
@davidzollo davidzollo changed the title [Fix-4054][Api] Fix The last week of the month for adding/editing tim… [Fix-4054][Api] Fix The last week of the month for adding/editing timing, preview and save timing will report an error Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingchun-chen xingchun-chen xingchun-chen approved these changes

@break60 break60 break60 approved these changes

Assignees
No one assigned
Labels
first time contributor First-time contributor UI ui and front end related
Projects
None yet
Milestone
1.3.4-release
Development

Successfully merging this pull request may close these issues.

[Bug][Api] The last week of the month for adding/editing timing, preview and save timing will report an error
4 participants
@iyeeku @break60 @xingchun-chen @CalvinKirs