Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] build project improvement #115

Merged
merged 8 commits into from
Mar 9, 2023
Merged

[Enhancement] build project improvement #115

merged 8 commits into from
Mar 9, 2023

Conversation

wolfboys
Copy link
Member

@wolfboys wolfboys commented Mar 8, 2023

Proposed changes

Issue Number: close #114

Problem Summary:

Currently, in the build.sh script. env checks such as thrift, java, maven, etc., needs to be optimized.

  1. thrift needs to verify the version is 0.13.0
  2. mvnw support(if not install maven)
  3. check java env need to improvement
  4. release process need to replace versions, see doc,this steps can be improved

Checklist(Required)

  1. Does it affect the original behavior: I Don't know
  2. Has unit tests been added: No
  3. Has document been added or modified: No
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@wolfboys
Copy link
Member Author

wolfboys commented Mar 8, 2023

cc @JNSimba @morningman PTAL thx

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit c819c72 into apache:master Mar 9, 2023
@wolfboys
Copy link
Member Author

wolfboys commented Mar 9, 2023

how-to-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] build project improvement
2 participants