Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix 1.1.1] fix use released memory bugs #10962

Conversation

jacktengg
Copy link
Contributor

Merge fix of #10777 to branch dev-1.1.1.

Proposed changes

Issue Number: close #xxx

Problem Summary:

Merge fix of #10777 to branch dev-1.1.1.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Merge fix of apache#10777 to branch dev-1.1.1.
@@ -57,10 +58,11 @@ std::string DataTypeNullable::to_string(const IColumn& column, size_t row_num) c
// <null array>: is_null1 | is_null2 | ...
// <values array>: value1 | value2 | ...>
int64_t DataTypeNullable::get_uncompressed_serialized_bytes(const IColumn& column) const {
auto ptr = column.convert_to_full_column_if_const();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some thing wrong here?

@yiguolei yiguolei changed the title [bugfix] fix use released memory bugs [bugfix 1.1.1] fix use released memory bugs Jul 18, 2022
@yiguolei yiguolei merged commit 24fe0fe into apache:dev-1.1.1 Jul 18, 2022
@yiguolei yiguolei mentioned this pull request Jul 22, 2022
@jacktengg jacktengg deleted the fix-use-of-convert_to_full_column_if_const branch August 1, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants