[Improvement](storage) reuse schema and rowblockv2 on single scanner_thread #11392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Userwhite
changed the title
dataroaring
requested changes
Aug 1, 2022
Userwhite
force-pushed
the
memory_resue_in_no_vec
branch
from
a4242b2
to
a96484d
Compare
Userwhite
force-pushed
the
memory_resue_in_no_vec
branch
from
a96484d
to
bdf3814
Compare
|
please review again？@dataroaring. I have fixed. thanks |
Userwhite
force-pushed
the
memory_resue_in_no_vec
branch
2 times, most recently
from
bdf3814
to
940a9a7
Compare
Userwhite
changed the title
|
@morningman-cmy hello, if have time, review it? |
Userwhite
force-pushed
the
memory_resue_in_no_vec
branch
from
0aca221
to
d55481e
Compare
wangbo
reviewed
Aug 19, 2022
wangbo
reviewed
Aug 19, 2022
Userwhite
force-pushed
the
memory_resue_in_no_vec
branch
from
ff7ba2a
to
5b9825f
Compare
dataroaring
reviewed
Aug 24, 2022
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
wsjz
pushed a commit
to wsjz/incubator-doris
that referenced
this pull request
Aug 24, 2022
…thread (apache#11392) * support reuse rowblockv2 on single thread
Userwhite
added a commit
to Userwhite/incubator-doris
that referenced
this pull request
Aug 30, 2022
…thread (apache#11392) * support reuse rowblockv2 on single thread
13 tasks
Closed
13 tasks
yiguolei
pushed a commit
that referenced
this pull request
Sep 5, 2022
…12322) #11392 made _input_block in each BetaRowsetReaders sharable. However, for some types (e.g. nested array with more than 1 depth), the _column_vector_batches in RowBlockV2 can be nested which means that there is a ColumnVectorBatch inside another ColumnVectorBatch. In this case, the data of inner ColumnVectorBatch may be corrupted because the data of _input_block is copied shallowly to the _output_block.
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Sep 14, 2022
…thread (apache#11392) (apache#12178) * support reuse rowblockv2 on single thread
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #11391
Problem summary
after change,rowblockv2 is not key
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...