[fix](orderby)remove useless null literal in order by #11821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrySnow
reviewed
Aug 17, 2022
| @@ -4740,12 +4740,16 @@ order_by_elements ::= | |||
| order_by_element:e | |||
| {: | |||
| ArrayList<OrderByElement> list = new ArrayList<OrderByElement>(); | |||
| list.add(e); | |||
| if (!(e.getExpr() instanceof NullLiteral)) { | |||
There was a problem hiding this comment.
i think we can remove all literal ?
morrySnow
previously approved these changes
Aug 17, 2022
starocean999
force-pushed
the
master_orderbynull
branch
from
f1ba28d
to
aee6e84
Compare
yiguolei
pushed a commit
that referenced
this pull request
Aug 19, 2022
Closed
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Sep 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
change "select * from table order by null" to "select * from table"
change "select * from table order by 1, null" to "select * from table order by 1"
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...